[popups] Don't let a late trigger claim a programmatically-opened popup#5031
Draft
atomiks wants to merge 1 commit into
Draft
[popups] Don't let a late trigger claim a programmatically-opened popup#5031atomiks wants to merge 1 commit into
atomiks wants to merge 1 commit into
Conversation
A trigger that mounts while a popup is already open (via a handle's openWithPayload/open(null)) would claim ownership and overwrite the programmatic payload. Track openedWithoutTrigger in the popup store and skip the implicit, registration-time, and single-trigger ARIA (aria-controls) claim paths for such opens; reset the flag on close so a later non-imperative open (controlled/defaultOpen) isn't affected. DialogHandle.open records trigger intent so handle.open(id) before mount still associates. Adds regression tests for payload preservation and the absent ARIA association. (B5)
atomiks
added
type: bug
commit: |
Bundle size
PerformanceTotal duration: 1,157.49 ms ▼-296.75 ms(-20.4%) | Renders: 50 (+0) | Paint: 1,735.65 ms ▼-448.73 ms(-20.5%)
7 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trigger that mounts while a popup is already open via a handle's
openWithPayload()/open(null)would claim ownership and overwrite the programmatically-set payload — contradictingopenWithPayload's contract ("does not associate the dialog with any trigger").Track
openedWithoutTriggerin the popup store and skip the registration-time claim, the implicit single-trigger claim, and the single-triggeraria-controlsassociation for such opens. The flag is reset on close so a later non-imperative open (controlledopen/defaultOpen) isn't affected.DialogHandle.open(id)records trigger intent so opening before the trigger mounts still associates correctly.This is shared popup infrastructure, so it also covers Popover/Menu detached triggers. Adds regression tests for payload preservation and the absent ARIA association.