[internal] Remove dead floating-ui-react focus-management code#5032
Draft
atomiks wants to merge 1 commit into
Draft
[internal] Remove dead floating-ui-react focus-management code#5032atomiks wants to merge 1 commit into
atomiks wants to merge 1 commit into
Conversation
atomiks
added
type: enhancement
commit: |
Bundle size
PerformanceTotal duration: 1,267.42 ms -186.82 ms(-12.8%) | Renders: 50 (+0) | Paint: 1,906.01 ms -278.38 ms(-12.7%)
10 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
internal/remove-dead-focus-code
branch
from
2c104cf to
8283d26
Compare
- Remove the never-passed renderGuards prop from FloatingPortal (S3).
- Remove the dead triggers.hasElement check subsumed by contains() (S6).
- Fix stale/misleading internal comments, including the inaccurate outside-press
return-focus comment (return focus is allowed only when focus({ preventScroll })
is supported, not 'always ignored').
atomiks
force-pushed
the
internal/remove-dead-focus-code
branch
from
8283d26 to
8aa000d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead-code removal + comment fixes in
floating-ui-react:renderGuardsprop fromFloatingPortal.triggers.hasElementcheck — it's subsumed by the followingcontains(trigger, relatedTarget)(true forparent === child, false for null).focus({ preventScroll })is supported).