Skip to content

[code-infra] Remove a few ts-ignore comments #43265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[code-infra] Remove a few ts-ignore comments #43265

wants to merge 14 commits into from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 11, 2024 •
edited
Loading

babysteps towards a healthier code base

  • Removing some obsolete // @ts-ignore comments.
  • Adjust typing to make some other obsolete
  • Install missing @types package
  • Replace some with // @ts-expect-error

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Aug 11, 2024
@mui-bot
Copy link

mui-bot commented Aug 11, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43265--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a9a815f

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 12, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 13, 2024
@Janpot Janpot marked this pull request as ready for review August 13, 2024 09:51
@zannager zannager requested a review from mnajdova August 13, 2024 13:45
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova Awaiting requested review from mnajdova

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @mui-bot