[docs][POC] Allow full screen demos #45785
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45785--material-ui.netlify.app/ Bundle size report |
Janpot
changed the title
cherniavskii
reviewed
Apr 1, 2025
| const scopedDemo = router.query.scopedDemo; | ||
| if (scopedDemo) { | ||
| return ( | ||
| <AppFrame disableDrawer> |
There was a problem hiding this comment.
Thank you, that was quick! 😅
Do we need the AppFrame for full-screen demos, though?
How about having a dedicated empty page, e.g. https://mui.com/playground?demo=material/components/buttons/BasicButtons.js
And a button in the toolbar that opens the playground url in a new tab?
There was a problem hiding this comment.
That would be harder to achieve but not impossible. in this PR we can basically surf on the existing generated infra for markdown demos.
cherniavskii
force-pushed
the
full-screen-demo
branch
from
96d0102 to
b35637c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with adding a mode to the docs demo pages to display a specific demo in full screen. This is just a POC.
example: https://deploy-preview-45785--material-ui.netlify.app/material-ui/react-button/?scopedDemo=BasicButtons.js
cc @cherniavskii