Skip to content

[material-ui][Chip] Add slots and slotProps #46098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented May 7, 2025

This PR adds slots and slotProps to Chip component

@sai6855 sai6855 changed the title Chip-slots [material-ui][Chip] Add slots and slotProps May 7, 2025
@sai6855 sai6855 added component: chip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature labels May 7, 2025
@mui-bot
Copy link

mui-bot commented May 7, 2025

Netlify deploy preview

https://deploy-preview-46098--material-ui.netlify.app/

@mui/material/Chip: parsed: +2.15% , gzip: +2.04%
@mui/material/Autocomplete: parsed: +0.22% , gzip: +0.19%
@mui/material: parsed: +0.06% , gzip: +0.06%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 6dc0d15

@sai6855 sai6855 marked this pull request as draft May 7, 2025 07:42
@sai6855 sai6855 requested a review from siriwatknp May 7, 2025 11:47
@sai6855 sai6855 marked this pull request as ready for review May 7, 2025 11:47
},
ownerState,
ref: handleRef,
shouldForwardComponentProp: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
shouldForwardComponentProp: true,

ChipRoot comes from div, no need to forward component prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: chip This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants