[docs-infra] Remove codesandbox #47046
Conversation
Janpot
added
the
scope: docs-infra
Netlify deploy previewhttps://deploy-preview-47046--material-ui.netlify.app/ Bundle size report
|
There was a problem hiding this comment.
The dashboard template is broken because this file was missing
| commitRef === undefined || | ||
| process.env.SOURCE_CODE_REPO !== 'https://github.com/mui/material-ui' | ||
| ) { | ||
| if (['joy', 'base'].includes(packageName)) { |
There was a problem hiding this comment.
this broke the templates for deploy previews. We're not generating pkg.pr.new packages for base/joy anymore
| import Visibility from '@mui/icons-material/Visibility'; | ||
| import CodeRoundedIcon from '@mui/icons-material/CodeRounded'; | ||
| import codeSandbox from 'docs/src/modules/sandbox/CodeSandbox'; | ||
| import Edit from '@mui/icons-material/Edit'; |
There was a problem hiding this comment.
I think a different icon would be better suited for this. The pencil makes me think it would start editing inline (like how GitHub works)
What do you think of Terminal, Code, Biotech, PrecisionManufacturing, Construction, DisplaySettings, or OpenInBrowser
There was a problem hiding this comment.
What do you think of
Terminal,Code,Biotech,PrecisionManufacturing,Construction,DisplaySettings, orOpenInBrowser
Sure, terminal could also make sense. In the templates page Code is already used for linking to the code on github.
The other options
-
-
-
-
-
-
-
-
ViewInAr:
Personally I still find the pencil most intuitive, but I don't have a strong opinion on this. Which do you think is best?
There was a problem hiding this comment.
I like Terminal the most since seeing the logs is the most noticeable difference between inline live-edit and StackBlitz. Another reason I dislike the pencil is that if we add live editing to Base UI, I think it would make sense to need to press the pencil to start live editing within the page. It would be interesting to hear what others think too.
There was a problem hiding this comment.
I also prefer Launch
In isolation, I like ViewInAr, but I find it too similar to the focus icon, which is two places to the side.
| import Visibility from '@mui/icons-material/Visibility'; | ||
| import CodeRoundedIcon from '@mui/icons-material/CodeRounded'; | ||
| import codeSandbox from 'docs/src/modules/sandbox/CodeSandbox'; | ||
| import Edit from '@mui/icons-material/Edit'; |
There was a problem hiding this comment.
import SandboxIcon from ...
5 participants
Remove stackblitz/codesandbox buttons and replace with a single "Open sandbox" button that opens StackBlitz with the demo/template.
Closes mui/mui-public#723
Some benchmarks for the button/icon
Chakra
Ariakit
React
HeroUI
Ant design