-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[docs][Autocomplete] Update virtualization example to use react-window v2 #47054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-47054--material-ui.netlify.app/ Bundle size report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sai6855 Maybe we should migrate our docs demos from react-window
and react-virtuoso
to @tanstack/react-virtual
, given its higher adoption. See: https://npmtrends.com/@tanstack/react-virtual-vs-react-virtualized-vs-react-virtuoso-vs-react-window. cc @siriwatknp
If you think it is not straightforward, I can review this PR. But first, what do you think of migrating to @tanstack/react-virtual
?
I agree that @tanstack/react-virtual has higher adoption, but since react-window still has around 3M downloads in the past year and the community is expecting a v2 versions of demos, I think it’s not ideal to completely migrate away from react-window. Maybe we can support both, but removing react-window entirely doesn’t seem ideal to me. |
Agree.
It's extremely painful to review as well. 😓 |
closes #46850
address https://mui-org.slack.com/archives/C0757QYLK7V/p1759503478232929
Initially i fixed this issue in #46900 but CI in that PR is failing for some reason i'm not aware of, moving changes to new PR fixed the CI. Additionally this PR also have fix reported by caspardue here #46900 (comment)
Migration to
react-window
v2 is extremely painful there is no official migration guide. I went through v2 docs and v1 docs to figure out what all changed.these are all the resources i could find.
Previews of all demos that effected by version upgrade
Regarding argos failure, I'm not really sure why it's failing. Looking at DOM of both v1 and v2, react-window has removed
outerElement
support andinnerElement
support (source), I suspect it is what causing argos issue. I think diff shown in argos is extremly minimal, since it's causing by external library and there is not enough guidance on migrartion, can we approve the change?