Skip to content

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Oct 9, 2025

closes #46850
address https://mui-org.slack.com/archives/C0757QYLK7V/p1759503478232929

Initially i fixed this issue in #46900 but CI in that PR is failing for some reason i'm not aware of, moving changes to new PR fixed the CI. Additionally this PR also have fix reported by caspardue here #46900 (comment)

Migration to react-window v2 is extremely painful there is no official migration guide. I went through v2 docs and v1 docs to figure out what all changed.

these are all the resources i could find.

  1. https://react-window.vercel.app/list/props
  2. Version 2.1.0 bvaughn/react-window#836
  3. Version 2 bvaughn/react-window#824

Previews of all demos that effected by version upgrade

Regarding argos failure, I'm not really sure why it's failing. Looking at DOM of both v1 and v2, react-window has removed outerElement support and innerElement support (source), I suspect it is what causing argos issue. I think diff shown in argos is extremly minimal, since it's causing by external library and there is not enough guidance on migrartion, can we approve the change?

@sai6855 sai6855 marked this pull request as draft October 9, 2025 13:18
@mui-bot
Copy link

mui-bot commented Oct 9, 2025

Netlify deploy preview

https://deploy-preview-47054--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against a94694c

@sai6855 sai6855 changed the title [docs] Update react-window package [docs][Autocomplete] Update virtualization example to use react-window v2 Oct 9, 2025
@sai6855 sai6855 added docs Improvements or additions to the documentation. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. support: docs-feedback Feedback from documentation page. labels Oct 9, 2025
@sai6855 sai6855 marked this pull request as ready for review October 9, 2025 13:58
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 13, 2025
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sai6855 Maybe we should migrate our docs demos from react-window and react-virtuoso to @tanstack/react-virtual, given its higher adoption. See: https://npmtrends.com/@tanstack/react-virtual-vs-react-virtualized-vs-react-virtuoso-vs-react-window. cc @siriwatknp

If you think it is not straightforward, I can review this PR. But first, what do you think of migrating to @tanstack/react-virtual?

@sai6855
Copy link
Contributor Author

sai6855 commented Oct 13, 2025

@sai6855 Maybe we should migrate our docs demos from react-window and react-virtuoso to @tanstack/react-virtual, given its higher adoption. See: https://npmtrends.com/@tanstack/react-virtual-vs-react-virtualized-vs-react-virtuoso-vs-react-window. cc @siriwatknp

If you think it is not straightforward, I can review this PR. But first, what do you think of migrating to @tanstack/react-virtual?

I agree that @tanstack/react-virtual has higher adoption, but since react-window still has around 3M downloads in the past year and the community is expecting a v2 versions of demos, I think it’s not ideal to completely migrate away from react-window. Maybe we can support both, but removing react-window entirely doesn’t seem ideal to me.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 13, 2025
@ZeeshanTamboli
Copy link
Member

@sai6855 Maybe we should migrate our docs demos from react-window and react-virtuoso to @tanstack/react-virtual, given its higher adoption. See: https://npmtrends.com/@tanstack/react-virtual-vs-react-virtualized-vs-react-virtuoso-vs-react-window. cc @siriwatknp
If you think it is not straightforward, I can review this PR. But first, what do you think of migrating to @tanstack/react-virtual?

I agree that @tanstack/react-virtual has higher adoption, but since react-window still has around 3M downloads in the past year and the community is expecting a v2 versions of demos, I think it’s not ideal to completely migrate away from react-window. Maybe we can support both, but removing react-window entirely doesn’t seem ideal to me.

Agree.

Migration to react-window v2 is extremely painful there is no official migration guide

It's extremely painful to review as well. 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. support: docs-feedback Feedback from documentation page.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Autocomplete Virtualization example not compatible with react-window v2

3 participants