[TextField] Fix Backspacing after line break in multiline causes heig… #47443
+122
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht issues on Safari
Netlify deploy previewhttps://deploy-preview-47443--material-ui.netlify.app/ Bundle size report
|
ZeeshanTamboli
added
scope: text field
mj12albert
reviewed
Dec 16, 2025
| const tempValue = textarea.value; | ||
| textarea.value = ''; | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-expressions | ||
| textarea.offsetHeight; |
Member
There was a problem hiding this comment.
Suggested change
| textarea.offsetHeight; | |
| void textarea.offsetHeight; |
Does this work instead of eslint-disable?
Author
There was a problem hiding this comment.
Yes, it worked without eslint-disable
|
|
||
| // This is a workaround for Safari/WebKit not reflowing text when the textarea height changes | ||
| // Force Safari to reflow the text by manipulating the textarea value | ||
| const containerDocument = ownerDocument(textarea); |
Member
There was a problem hiding this comment.
If it's just webkit we could wrap this change with a check:
const isWebKit = typeof CSS === 'undefined' || !CSS.supports
? false
: CSS.supports('-webkit-backdrop-filter:none');
Author
There was a problem hiding this comment.
Wrapped the changes to work only in WebKit
Author
|
Thank you, @mj12albert, for reviewing the PR. Required changes are done, please review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first Open source contribution. This PR fixes an issue in
TextFieldheight when the multiline prop is passed.Root Cause
In safari when textarea height is reduced programmatically, Safari updates the height but does not recalculate text line wrapping & caret position. Chrome handles this correctly
Proposed Fix
We can force textline wrapping recalculation in Safari by changing the textArea width.
Fixes
Fixes #45293