[Checkbox] Set the native indeterminate state on the input - #49053
Open
lazerg wants to merge 2 commits into
Open
[Checkbox] Set the native indeterminate state on the input#49053lazerg wants to merge 2 commits into
lazerg wants to merge 2 commits into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkboxsetsaria-checked="mixed"whenindeterminateis true, but the input's nativeindeterminateproperty is never set. The two disagree, so axe reports anaria-conditional-attrviolation ("Remove aria-checked, or set it to false to match the real checkbox state"), and browsers that expose the mixed state from the native property alone never report it.React does not forward
indeterminateto the DOM, so the property is assigned through a ref on the input slot, and reapplied on change since activating a checkbox clears it. The prop description said the native state was left alone on purpose, which is no longer true, so it and the generated API docs are updated.Fixes #49051