[SpeedDial] Support action slot object refs - #49056
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SpeedDialAction slotProps.fab.refwhen it is an object ref such asReact.createRef(); the current implementation calls the ref as a function and throws.nullcallback.The wrapper now delegates non-function refs to MUI's existing
setRefhelper and returns callback-ref cleanup values.Verification
pnpm test:unit run SpeedDial --project 'node:@mui/material'pnpm -F @mui/material typescriptpnpm release:build.The browser test project was not run locally because Playwright Chromium is not installed in this checkout.
Contribution
This change and PR description were prepared with OpenAI Codex, then self-reviewed and verified locally. No independent human review has occurred yet.