Claude review: read the review from the agent's final message by Janpot · Pull Request #1796 · mui/mui-public

Janpot · 2026-08-19T14:21:42Z

Forcing the review back through --json-schema made the agent re-emit it into a review field, and that copy was mis-formatted intermittently:

= PLACEHOLDER = — the agent stubbed the field instead of copying the review (seen on a real PR).
The whole review double-wrapped as JSON — review held {"review":"…"}, so the raw JSON got posted (base-ui#5455).

Both are the same failure: a redundant re-emit of a long block the agent already produced. This drops --json-schema entirely and reads the review from the agent's plain final message (.result of the execution log's result entry, which the Publish step already opens for the cost/turn stats). The agent produces the review once; there's no field to mis-format, so both failure modes are structurally impossible. Agent still has zero write tools.

Note: I couldn't run the local end-to-end validation this session (the worktree-isolation guard blocks nested claude runs), so the final confirmation is a CI smoke-test — one @claude review on a PR after this merges.

code-infra-dashboard · 2026-08-19T14:22:34Z

Deploy preview

https://deploy-preview-1796--mui-internal.netlify.app/

Bundle size

Total Size Change: 0B^(0.00%) - Total Gzip Change: 0B^(0.00%)
Files: 71 total (0 added, 0 removed, 0 changed)

Show details for 71 more bundles

@mui/internal-docs-infra/abstractCreateDemo parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/abstractCreateDemoClient parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/abstractCreateStream parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/abstractCreateTypes parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/ChunkProvider parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/cli parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/CodeControllerContext parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/CodeExternalsContext parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/CodeHighlighter parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/CodeHighlighter/errors parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/CodeHighlighter/types parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/CodeProvider parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/CoordinatedLazy parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/CoordinatedLazy/types parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/createDemoData parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/createDemoData/types parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/createSitemap parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/createSitemap/types parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useCode parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useCodeWindow parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useCoordinated parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useCopier parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useCrossTabState parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useDemo parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useDemoController parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useErrors parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useLocalStorageState parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/usePreference parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useScrollAnchor parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useSearch parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useSearch/types parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useStream parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useStream/types parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useType parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useTypes parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/useUrlHashState parsed: 0B^(0.00%) gzip: 0B^(0.00%)
@mui/internal-docs-infra/withDocsInfra parsed: 0B^(0.00%) gzip: 0B^(0.00%)
addLineGutters parsed: 0B^(0.00%) gzip: 0B^(0.00%)
BuildEngine parsed: 0B^(0.00%) gzip: 0B^(0.00%)
CodeHighlighterChunk parsed: 0B^(0.00%) gzip: 0B^(0.00%)
CodeHighlighterClient parsed: 0B^(0.00%) gzip: 0B^(0.00%)
CodeInitialSourceLoader parsed: 0B^(0.00%) gzip: 0B^(0.00%)
CodeSourceLoader parsed: 0B^(0.00%) gzip: 0B^(0.00%)
compileCssWithPostcss parsed: 0B^(0.00%) gzip: 0B^(0.00%)
computeHastDeltas parsed: 0B^(0.00%) gzip: 0B^(0.00%)
createFrame parsed: 0B^(0.00%) gzip: 0B^(0.00%)
createParseSourceWorkerClient parsed: 0B^(0.00%) gzip: 0B^(0.00%)
EditingEngine parsed: 0B^(0.00%) gzip: 0B^(0.00%)
embedTransforms parsed: 0B^(0.00%) gzip: 0B^(0.00%)
enhanceCodeEmphasis parsed: 0B^(0.00%) gzip: 0B^(0.00%)
findExpandingRanges parsed: 0B^(0.00%) gzip: 0B^(0.00%)
getHastTextContent parsed: 0B^(0.00%) gzip: 0B^(0.00%)
grammarLoaders parsed: 0B^(0.00%) gzip: 0B^(0.00%)
grammars parsed: 0B^(0.00%) gzip: 0B^(0.00%)
isFrameSpan parsed: 0B^(0.00%) gzip: 0B^(0.00%)
loadCodeFallback parsed: 0B^(0.00%) gzip: 0B^(0.00%)
loadIsomorphicCodeVariant parsed: 0B^(0.00%) gzip: 0B^(0.00%)
parseSource parsed: 0B^(0.00%) gzip: 0B^(0.00%)
rolldown-runtime parsed: 0B^(0.00%) gzip: 0B^(0.00%)
source.css parsed: 0B^(0.00%) gzip: 0B^(0.00%)
source.js parsed: 0B^(0.00%) gzip: 0B^(0.00%)
source.json parsed: 0B^(0.00%) gzip: 0B^(0.00%)
source.mdx parsed: 0B^(0.00%) gzip: 0B^(0.00%)
source.shell parsed: 0B^(0.00%) gzip: 0B^(0.00%)
source.ts parsed: 0B^(0.00%) gzip: 0B^(0.00%)
source.tsx parsed: 0B^(0.00%) gzip: 0B^(0.00%)
source.yaml parsed: 0B^(0.00%) gzip: 0B^(0.00%)
text.html.basic parsed: 0B^(0.00%) gzip: 0B^(0.00%)
text.md parsed: 0B^(0.00%) gzip: 0B^(0.00%)
TransformEngine parsed: 0B^(0.00%) gzip: 0B^(0.00%)
transpileSource parsed: 0B^(0.00%) gzip: 0B^(0.00%)

Details of bundle changes

Performance

Total duration: 17.58 ms +2.28 ms^(+14.9%) | Renders: 5 ⁽⁺⁰⁾ | Paint: 61.25 ms +3.85 ms^(+6.7%)

Test	Duration	Renders
HeavyList mount	9.23 ms 🔺+1.61 ms^(+21.2%)	1 ⁽⁺⁰⁾
DataGrid mount with paint timing	2.05 ms 🔺+0.58 ms^(+39.5%)	1 ⁽⁺⁰⁾
custom scalar + discrete metrics	0.00 ms	0 ⁽⁺⁰⁾
sub-series via labels	0.00 ms	0 ⁽⁺⁰⁾

3 tests within noise — details

Metric alarms

Test	Metric	Change
HeavyList mount	bench:paint	🔺 +7.03 ms
custom scalar + discrete metrics	fib_duration	🔺 +0.24 ms
sub-series via labels	fib_phase#small	🔺 +0.02 ms
sub-series via labels	fib_phase#large	🔺 +0.72 ms

Check out the code infra dashboard for more information about this PR.

Copilot

Pull request overview

This PR updates the Claude review GitHub Actions workflow to stop using --json-schema structured output and instead publish the agent’s review directly from the agent’s plain final message stored in the execution log result entry, eliminating intermittent mis-formatting failures caused by re-emitting the review into a JSON field.

Changes:

Remove the --json-schema requirement so the agent produces the review only once (as its final message).
Adjust the prompt contract so the agent’s final message is the complete Markdown review (no preamble/sign-off).
Update the “Publish review” step to read both cost stats and the review body from the execution log’s result entry (runResult.result) instead of structured_output.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

…ct-review

Claude review: read the review from the final message, not --json-schema

cf2a019

Janpot requested a lite review from Copilot August 19, 2026 14:28

Copilot started reviewing on behalf of Janpot August 19, 2026 14:29 View session

Copilot AI reviewed Aug 19, 2026

View reviewed changes

Don't publish a failed run's error text as the review

61b2ea3

Janpot requested a lite review from Copilot August 26, 2026 12:25

Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Aug 26, 2026

Copilot started reviewing on behalf of Janpot August 26, 2026 12:25 View session

Copilot AI reviewed Aug 26, 2026

View reviewed changes

Comment thread .github/workflows/claude-review.yml Outdated

Janpot added 5 commits August 26, 2026 14:31

Gate on the step outcome and summarise a failed run's reason

23c40c5

Merge remote-tracking branch 'origin/master' into claude-review-extra…

e0a06fb

…ct-review

Merge remote-tracking branch 'origin/master' into claude-review-extra…

62024e7

…ct-review

Publish a review that overran the turn budget instead of discarding it

cace29f

Describe the allowlist and transcript upload as they stand

fa4ea46

Janpot requested a review from a team August 28, 2026 15:05

Janpot marked this pull request as ready for review August 28, 2026 15:05

Name the failure when a run stops without producing text

c23c1ee

Navigation Menu

Uh oh!

Claude review: read the review from the agent's final message - #1796

Claude review: read the review from the agent's final message#1796
Janpot wants to merge 8 commits into
masterfrom
claude-review-extract-review

Janpot commented Aug 19, 2026

Uh oh!

code-infra-dashboard Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Janpot commented Aug 19, 2026

Uh oh!

code-infra-dashboard Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy preview

Bundle size

Performance

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

code-infra-dashboard Bot commented Aug 19, 2026 •

edited

Loading