Skip to content

[DataGrid] Fix unnecessary firing of onFetchRows on initial load #14030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[DataGrid] Fix unnecessary firing of onFetchRows on initial load #14030

wants to merge 3 commits into from

Conversation

rafael-lopes-rlabs
Copy link

@rafael-lopes-rlabs rafael-lopes-rlabs commented Jul 30, 2024 •
edited by MBilalShafi
Loading

Fixes: #13994

@rafael-lopes-rlabs rafael-lopes-rlabs mentioned this pull request Jul 30, 2024
Open
@mui-bot
Copy link

mui-bot commented Jul 30, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14030--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 14d5ef8

@MBilalShafi
Copy link
Member

Hey @rafael-lopes-rlabs, thank you for the PR.
I can see some unrelated changes. Could you rebase your branch with the latest master branch to remove those changes from the diff?

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Server integration Better integration with backends, e.g. data source labels Jul 30, 2024
@rafael-lopes-rlabs
Copy link
Author

Hey @MBilalShafi,

I've already rebased my branch with master, but there are still some unrelated changes showing up in the diff...

@zannager zannager requested a review from MBilalShafi October 17, 2024 12:04
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@JanVercammen89
Copy link

Small poke to fix the conflicts merging. Patch is working as intended.

@github-actions GitHub Actions
Copy link

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

@github-actions github-actions bot added the stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity. label Apr 20, 2025
@MBilalShafi MBilalShafi removed the stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity. label May 1, 2025
@MBilalShafi MBilalShafi changed the title fix: Using initialState with sort, will trigger a onFetchRows function call on first load [DataGrid] Fix unnecessary firing of onFetchRows on initial load May 1, 2025
@MBilalShafi MBilalShafi force-pushed the fix-onfetchrows-initial-trigger-on-initialstate-set branch from f09f83a to 6e3fa7a Compare May 1, 2025 15:10
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 1, 2025
@MBilalShafi MBilalShafi requested a review from a team May 1, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Server integration Better integration with backends, e.g. data source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Using initialState with sort, will trigger a onFetchRows function call on first load
4 participants
@rafael-lopes-rlabs @mui-bot @MBilalShafi @JanVercammen89