Skip to content

[data grid] Fix no content and wrong page/size on large row view #14737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[data grid] Fix no content and wrong page/size on large row view #14737

wants to merge 1 commit into from

Conversation

campmarc
Copy link

@campmarc campmarc commented Sep 26, 2024 •
edited
Loading

When either

  • zooming very close
  • the viewport get too small due to window resize or
  • row item is generally high and thus higher than DataGrid inner height

DataGrid should still at least show one row - even if it doesn't wholly fit.

Currently it does not show any content and displays wrong pagecount and pagesize.

@mui-bot
Copy link

mui-bot commented Sep 26, 2024

Deploy preview: https://deploy-preview-14737--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d145a12

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Sep 26, 2024
@flaviendelangle flaviendelangle changed the title [mui-x][DataGrid] fix no content and wrong page/size on large row view [data grid] fix no content and wrong page/size on large row view Sep 30, 2024
@flaviendelangle flaviendelangle changed the title [data grid] fix no content and wrong page/size on large row view [data grid] Fix no content and wrong page/size on large row view Sep 30, 2024
@github-actions GitHub Actions
Copy link

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

@github-actions github-actions bot added the stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity. label Mar 25, 2025
@campmarc
Copy link
Author

keep it open

@github-actions github-actions bot removed the stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity. label Mar 26, 2025
@github-actions GitHub Actions
Copy link

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

@github-actions github-actions bot added the stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity. label Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! stale This PR has been inactive for more than 30 days. It will get closed after 90 days of inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@campmarc @mui-bot @zannager