Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix flaky browser tests #16179

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −2
Draft

[test] Fix flaky browser tests #16179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5531873
fix flaky browser tests
cherniavskii Jan 14, 2025
b1ae206
use getBy query so it throws in waitFor
cherniavskii Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/x-data-grid-premium/src/tests/dataSourceAggregation.DataGridPremium.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,17 @@ describe('<DataGridPremium /> - Data source aggregation', () => {
it('should show aggregation option in the column menu', async () => {
const { user } = render(<TestDataSourceAggregation />);
await user.click(within(getColumnHeaderCell(0)).getByLabelText('Menu'));
expect(screen.queryByLabelText('Aggregation')).not.to.equal(null);
await waitFor(() => {
expect(screen.getByLabelText('Aggregation')).not.to.equal(null);
});
});

it('should not show aggregation option in the column menu when no aggregation function is defined', async () => {
const { user } = render(<TestDataSourceAggregation aggregationFunctions={{}} />);
await user.click(within(getColumnHeaderCell(0)).getByLabelText('Menu'));
expect(screen.queryByLabelText('Aggregation')).to.equal(null);
await waitFor(() => {
expect(screen.getByLabelText('Aggregation')).to.equal(null);
});
});

it('should provide the `aggregationModel` in the `getRows` params', async () => {
Expand Down
Loading