-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[DataGrid] Update vertical scrollbar position to cover pinned rows #16476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[DataGrid] Update vertical scrollbar position to cover pinned rows #16476
Conversation
Deploy preview: https://deploy-preview-16476--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: @mui/x-data-grid-premium parsed: Show 13 more bundle changes@mui/x-charts-pro parsed: 0B(0.00%) gzip: |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
bottom: 0, | ||
}); | ||
|
||
export const ScrollbarCorner = styled(Scrollbar)({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[`& .${c['main--hiddenContent']}`]: { | ||
// Position vertical scrollbar and fillers out of grid viewport | ||
marginRight: 'calc(var(--DataGrid-scrollbarSize) * -1)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the easiest way to ensure the horizontal scrollbar is the correct width and the vertical and corner scrollbar are hidden. Also removes the need for fillers in the skeleton loader rows.
89a113a
to
9707912
Compare
Tbh I love the design as it is. I feel like it makes the grid with pinned rows a bit more readable as to which is the pinned vs unpinned section. I wonder if we could use the current styling for a grid with pinned rows, and the new styling for the case when there's no pinned rows? |
Continuation of #16379
Fixes #13286