[charts-pro] Zoom pointer improvements #17000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…events-improvement
…events-improvement
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
JCQuintas
force-pushed
the
pointer-events-improvement
branch
from
76ab4f5 to
0edea79
Compare
Comment on lines
29
to
31
| xAxis={[ | ||
| { | ||
| zoom: true, |
Member
There was a problem hiding this comment.
If you'r lookig for what triggers the re-render. I'ts probably the xAxis
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…events-improvement
github-actions
bot
removed
the
PR: out-of-date
…events-improvement
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days. |
github-actions
bot
added
the
stale
|
This pull request has been closed due to 15 days of inactivity after being marked stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16205
Main change
Use
use-gestureto recognise the gestures. Right now the lib is a bit slow to have updates, but it has some solid behaviour detection.Create a
interaction listenerplugin. This allows us to register events directly in the SVG.The current implementation migrates most of the interactions to the schema below.
Other changes
BarChartPro,LineChartPro, andScatterChartProfireEvent/element.dispatchEvent), but couldn't figure out a way to make it work.usePanOnDrag,useZoomOnPinchanduseZoomOnWheelhooks