[test] Fix flaky data source aggregation test (take 3) #17316
Conversation
LukasTy
added
test
component: data grid
|
Deploy preview: https://deploy-preview-17316--material-ui-x.netlify.app/ |
| @@ -104,6 +104,8 @@ describeSkipIf(isJSDOM)('<DataGridPremium /> - Data source aggregation', () => { | |||
| expect(fetchRowsSpy.callCount).to.be.greaterThan(0); | |||
| }); | |||
| await user.click(within(getColumnHeaderCell(0)).getByLabelText('id column menu')); | |||
| // wait for the column menu to be open first | |||
| await screen.findByRole('menu', { name: 'id column menu' }); | |||
There was a problem hiding this comment.
What a nasty test to fix 😅
Do you think this will make any difference?
There was a problem hiding this comment.
I'm no longer sure... 🤷
It's hard to debug it when locally it's impossible to get a failure. 🙈
But at least on Pickers, I often tend to first assert that a Popper has been attached and only then do the actual assertion. 🤔
There was a problem hiding this comment.
The popper tests are extremely frustrating to test. There is no exact reason why they fail as far as I could tell
There was a problem hiding this comment.
And it failed once again... 🤷
|
@MBilalShafi thank you for pitching it. 🙏 However, I haven't seen this test acting flaky lately, maybe we should wait for an indicator that it is still flaky..? 🤷 |
|
I guess it doesn't do any harm to merge it as it could reproduce again since the factor causing flakiness ("async" behavior of |
Gotcha. Could I get approval on the PR? 🤔 |
Follow up on #17311.
Seems to still be failing. 🙈 🤷
https://app.circleci.com/pipelines/github/mui/mui-x/88253/workflows/cfe4f5a8-dac0-4fac-a889-acb5e84b3044/jobs/509320