[charts] Fix axis types not narrowing #17321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
bernardobelchior
added
bug 🐛
|
Deploy preview: https://deploy-preview-17321--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #17321 will not alter performanceComparing Summary
|
| @@ -56,7 +55,7 @@ function getCategoryAxisConfig( | |||
| id: direction === 'x' ? DEFAULT_X_AXIS_KEY : DEFAULT_Y_AXIS_KEY, | |||
| ...categoryAxis, | |||
| ...(categoryAxis?.size ? { [isHorizontal ? 'height' : 'width']: categoryAxis.size } : {}), | |||
| position: categoryAxis?.position ?? (categoryAxis?.categories ? side : 'none'), | |||
| position: (categoryAxis?.position ?? (categoryAxis?.categories ? side : 'none')) as any, | |||
There was a problem hiding this comment.
This fixes a type error. I'm not sure how I could fix it otherwise. The cause seems to be that TS doesn't know which positions are valid depending on isHorizontal.
There was a problem hiding this comment.
I pushed a fix. The issues seems to the categorical axis type that was not distributing the union.
bernardobelchior
requested review from
alexfauquette and
JCQuintas
and removed request for
alexfauquette
bernardobelchior
force-pushed
the
improve-axis-types
branch
from
937bdd2 to
b9bb170
Compare
…x into improve-axis-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10334.
Fixes axis type not narrowing when given a
scaleType. Fix suggested by @alexfauquette here.