[docs] Remove ad on paid docs pages #17373

oliviertassinari · 2025-04-15T13:19:55Z

Remove ad on paid docs pages, and fix some small docs issues along the way.

mui-bot · 2025-04-15T13:23:07Z

Deploy preview: https://deploy-preview-17373--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against fea8258

oliviertassinari · 2025-04-15T13:25:53Z

docs/data/charts/zoom-and-pan/zoom-and-pan.md

@@ -1,5 +1,5 @@
 ---
-title: Charts - Zooming and panning
+title: Charts - Zoom and pan


To match the link in the sidenav

oliviertassinari · 2025-04-15T13:26:08Z

docs/data/data-grid/components/columns-panel/columns-panel.md

 ---

-# Data Grid - Columns Panel 🚧
+# Data Grid - Columns panel 🚧


Sentence case seem to apply here

What's the reason for the change? We are referring to the component name here which is Columns Panel.

The default is sentence case, I didn't understand why it uses title case, so went back to the default.

I'm reverting this though, for the sake of having smaller more focused PRs. (not the title, I don't see how the title can be correct, but the changes in the body)

not the title, I don't see how the title can be correct

It is consistent with other docs pages where we refer to the component name, for example:

I think the difference is that

"Date Time" is a reference to our date time component to disambiguate with a date time component that people already know. "Column Panel" is not a component that people already know.

"Date Time" is a reference to a product, assuming we define product as something that people can use on its own.

"Date Time" is a reference to our date time component to disambiguate with a date time component that people already know. "Column Panel" is not a component that people already know.

I'm not sure I understand this logic — I don't see why it would make a difference whether people know it or not.

"Columns Panel" is consistent with our convention for component naming.

Maybe @mapache-salvaje can help us with the correct casing here? 😅

According to our style conventions all MUI components should be treated as proper nouns (aka "Title Case") so "Columns Panel" is correct.

I don't see why it would make a difference whether people know it or not

@kenanyusuf How I understand each:

Date Picker = https://mui.com/x/react-date-pickers/date-picker/
DatePicker or <DatePicker> = https://mui.com/x/api/date-pickers/date-picker/
date picker = https://en.wikipedia.org/wiki/Date_picker

In this case,

Columns Panel = doesn't exist.
ColumnsPanel = doesn't exist, ColumnsPanelTrigger exists
columns panel = https://mui.com/x/react-data-grid/components/columns-panel/

According to our style conventions all MUI components should be treated as proper nouns (aka "Title Case") so "Columns Panel" is correct.

@mapache-salvaje By following https://www.notion.so/mui-org/Style-conventions-for-MUI-components-and-products-dff7d2d7d1ba4a4abd47f48cf345b800 I land on this:

-# Data Grid - Columns Panel 🚧 +# Data Grid - Columns panel 🚧 // none of case 1, 2, 3 applies, so it's default to sentence case) -### Columns Panel Trigger +### <ColumnsPanelTrigger> (case 3 applies, but it's a header so no backtick) `<ColumnsPanelTrigger />` is a button that opens and closes the columns panel. It renders the `baseButton` slot.

but I have reverted this, to keep the PR focused.

oliviertassinari · 2025-04-15T13:26:53Z

docs/data/tree-view/rich-tree-view/lazy-loading/lazy-loading.md

-# Rich Tree View - Lazy loading
+# Rich Tree View - Lazy loading [<span class="plan-pro"></span>](/x/introduction/licensing/#pro-plan 'Pro plan')


This is Pro

oliviertassinari · 2025-04-15T13:31:07Z

docs/pages/x/react-data-grid/components/pivot-panel.js


 export default function Page() {
-  return <MarkdownDocs {...pageProps} />;
+  return <MarkdownDocs disableAd {...pageProps} />;


https://master--material-ui-x.netlify.app/x/react-data-grid/components/pivot-panel/

oliviertassinari · 2025-04-15T13:31:16Z

docs/pages/x/react-data-grid/recipes-row-grouping.js


 export default function Page() {
-  return <MarkdownDocs {...pageProps} />;
+  return <MarkdownDocs disableAd {...pageProps} />;


https://master--material-ui-x.netlify.app/x/react-data-grid/recipes-row-grouping/

oliviertassinari · 2025-04-15T13:31:21Z

docs/pages/x/react-tree-view/rich-tree-view/lazy-loading.js


 export default function Page() {
-  return <MarkdownDocs {...pageProps} />;
+  return <MarkdownDocs disableAd {...pageProps} />;


https://master--material-ui-x.netlify.app/x/react-tree-view/rich-tree-view/lazy-loading/

github-actions · 2025-04-15T16:15:17Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-04-16T07:51:41Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

oliviertassinari added the docs Improvements or additions to the documentation. label Apr 15, 2025

oliviertassinari added the type: bug It doesn't behave as expected. label Apr 15, 2025

oliviertassinari commented Apr 15, 2025

View reviewed changes

oliviertassinari requested a review from kenanyusuf April 15, 2025 13:57

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 15, 2025

oliviertassinari force-pushed the fix-ad-display branch from e290df2 to df88f5c Compare April 15, 2025 17:09

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Apr 15, 2025

oliviertassinari added 6 commits April 18, 2025 01:34

[docs] Remove ad on paid docs pages

f5e8f07

one more

2ec1796

fix ci

d58f248

scope down the changes

df25290

keep pr more focused

66714a4

keep pr more focused

e9bbcc7

oliviertassinari force-pushed the fix-ad-display branch from 37b5413 to ff5bd3f Compare April 17, 2025 23:35

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 17, 2025

oliviertassinari force-pushed the fix-ad-display branch from ff5bd3f to 70dbc4f Compare April 17, 2025 23:36

keep pr more focused

fea8258

oliviertassinari force-pushed the fix-ad-display branch from 70dbc4f to fea8258 Compare April 17, 2025 23:37

kenanyusuf approved these changes Apr 22, 2025

View reviewed changes

oliviertassinari merged commit 7cfbcc6 into mui:master Apr 22, 2025
21 checks passed

oliviertassinari deleted the fix-ad-display branch April 22, 2025 13:55

		# Rich Tree View - Lazy loading
		# Rich Tree View - Lazy loading [<span class="plan-pro"></span>](/x/introduction/licensing/#pro-plan 'Pro plan')

Uh oh!

[docs] Remove ad on paid docs pages #17373

[docs] Remove ad on paid docs pages #17373

Uh oh!

Conversation

oliviertassinari commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mapache-salvaje Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oliviertassinari commented Apr 15, 2025 •

edited

Loading

mui-bot commented Apr 15, 2025 •

edited

Loading

oliviertassinari Apr 15, 2025 •

edited

Loading

oliviertassinari Apr 15, 2025 •

edited

Loading

mapache-salvaje Apr 17, 2025 •

edited

Loading

oliviertassinari Apr 17, 2025 •

edited

Loading