-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[docs] Add CSS bundler breaking change to migration guide #17436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Deploy preview: https://deploy-preview-17436--material-ui-x.netlify.app/ Updated pages: |
### Bundling | ||
|
||
The Data Grid now requires a bundler that can handle CSS imports. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's cover some popular setups here.
- Next.js Pages router: [data grid][docs] CSS loader needed for x-data-grid v8.0.0? #17427 (comment)
- Webpack
- Vitest [data grid][docs] CSS loader needed for x-data-grid v8.0.0? #17427 (comment)
- ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What level of detail do you have in mind? Just a link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like https://mui.com/x/migration/usage-with-material-ui-v5-v6/, with code snippets and links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To what I understand Joy UI has the same requirements. So let's have Core review on this one. X can be responsible to fix this but Core should be accountable for this.
cc @DiegoAndai |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Follow-up of #17427