[charts] Default bar chart x-axis scale type to band #17519
+132
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
bernardobelchior
added
new feature
|
Deploy preview: https://deploy-preview-17519--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #17519 will not alter performanceComparing Summary
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
bernardobelchior
force-pushed
the
default-bar-chart-x-axis-scale-type
branch
from
6392f2a to
c23dab3
Compare
github-actions
bot
removed
the
PR: out-of-date
bernardobelchior
requested review from
alexfauquette and
JCQuintas
and removed request for
alexfauquette
Comment on lines
99
to
103
| const defaultXAxis = hasHorizontalSeries ? undefined : defaultBandXAxis; | ||
| const processedXAxis = React.useMemo( | ||
| () => (xAxis ? xAxis.map((axis) => ({ scaleType: 'band' as const, ...axis })) : defaultXAxis), | ||
| [defaultXAxis, xAxis], | ||
| ); |
There was a problem hiding this comment.
If I get it correctly, this causes issues with the following config. Even if the layout is horizontal, the xAxis will get a band scale, which is not the expected behavior
<BarChart
xAxis={[{ min: 0, max: 100 }]}
layout="horizontal"
{...}
/>There was a problem hiding this comment.
Good point. Didn't think of the horizontal case. Will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13794.
This fix surfaced an issue that applies to all charts when
scaleTypeisn't defined andvalueFormatteris. In that case, a type error will show because the values will implicitly haveanyas a type. To fix that, I added backscaleType: 'band'in some examples (commit).We either have wrong types or are facing a limit in TypeScript, not sure which. However, this seems to only apply for certain TypeScript configurations (
noImplicitAny: true), so this isn't a major issue IMO and this PR is an improvement over the current state of things.