Skip to content

[code-infra] Add test case for core charts issue #17612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 29, 2025

Introduce new release:test command to run tests that only work after release:build. Used it to build a reproduction case for the mui/material-ui#45990

Copy link

Please add one type label to categorize the purpose of this PR appropriately:

bug, regression, enhancement, new feature, release or dependencies

@mui-bot
Copy link

mui-bot commented Apr 29, 2025

Deploy preview: https://deploy-preview-17612--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 07c5d50

@alexfauquette
Copy link
Member

I tried to go a bit further in the bisection.

I tried to isolate the part of the pipeline that's breaking. To do so, I've took an other props highligtedItem that fails when running pnpm -F @mui/x-test-typescript typescript too.

And I re-implemented the props Type step by step removing the stuff that are not necessary for the definition on highligtedItem whihc is defined in the useChartHighlight pluggin (typed by UseChartHighlightSignature).

It stopped breaking when I isolated the pluggin removed the ...ChartCorePluginSignatures.

MergeSignaturesProperty<
      [
        // ...ChartCorePluginSignatures,
        ...TSignatures,
      ],
      'params'
    >

With the current state, the pnpm -F @mui/x-test-typescript typescript does not break, but uncommenting // ...ChartCorePluginSignatures makes it break

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 1, 2025
Copy link

github-actions bot commented May 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 1, 2025
@Janpot Janpot changed the title [code-infra] Reproduce strange core charts issue [code-infra] Add test case for core charts issue May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants