Skip to content

[fields] Add notch to the field outlined when the label is manually shrinked #17620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fields] Add notch to the field outlined when the label is manually shrinked #17620

wants to merge 1 commit into from
+9 −0

Conversation

flaviendelangle
Copy link
Member

Logic taken from @mui/material

Closes #17605

@flaviendelangle flaviendelangle self-assigned this Apr 30, 2025
@flaviendelangle flaviendelangle added regression 🐛 A bug, but worse component: pickers This is the name of the generic UI component, not the React module! labels Apr 30, 2025
@mui-bot
Copy link

mui-bot commented Apr 30, 2025

Deploy preview: https://deploy-preview-17620--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7413671

@flaviendelangle flaviendelangle marked this pull request as ready for review April 30, 2025 05:56
LukasTy
LukasTy approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of it! 🙏

Nitpick: this case shows the need for placeholder behavior. 🙈
Am I missing something or is there a way to pass placeholder for the unfocused state? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! regression 🐛 A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] Input label styling is broken with shrink true
3 participants
@flaviendelangle @mui-bot @LukasTy