Skip to content

[l10n] Improve Finnish (fi-FI) locale #17621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laurisaksi
Copy link

@laurisaksi laurisaksi commented Apr 30, 2025

Signed-off-by: Lauri Saksi <[email protected]>
Copy link

Please add one type label to categorize the purpose of this PR appropriately:

bug, regression, enhancement, new feature, release or dependencies

@mui-bot
Copy link

mui-bot commented Apr 30, 2025

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-17621--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d33fcdd

@laurisaksi laurisaksi marked this pull request as draft April 30, 2025 06:57
@@ -42,7 +42,7 @@ const fiFIPickers: Partial<PickersLocaleText> = {
dateTimePickerToolbarTitle: 'Valitse päivä ja aika',
timePickerToolbarTitle: 'Valitse aika',
dateRangePickerToolbarTitle: 'Valitse aikaväli',
// timeRangePickerToolbarTitle: 'Select time range',
timeRangePickerToolbarTitle: 'Valitse aikaväli',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the above be Valitse päivämääräväli instead? 🤔
At least based on Google Translate, this equals "Select a time interval", which does not sound completely correct given the English translation of "Select date range". 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants