Skip to content

[charts] Add zoom slider tooltip #17733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented May 7, 2025

Part of #15383.

Screen.Recording.2025-05-07.at.09.53.31.mov

@bernardobelchior bernardobelchior added new feature New feature or request component: charts This is the name of the generic UI component, not the React module! labels May 7, 2025
@mui-bot
Copy link

mui-bot commented May 7, 2025

Deploy preview: https://deploy-preview-17733--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ea0cc40

Copy link

codspeed-hq bot commented May 7, 2025

CodSpeed Performance Report

Merging #17733 will not alter performance

Comparing bernardobelchior:add-zoom-slider-tooltip (ea0cc40) with master (13afafe)

Summary

✅ 8 untouched benchmarks

@bernardobelchior bernardobelchior force-pushed the add-zoom-slider-tooltip branch from 35054c8 to 0438c95 Compare May 7, 2025 07:55
@bernardobelchior bernardobelchior force-pushed the add-zoom-slider-tooltip branch from 0438c95 to ab8104b Compare May 7, 2025 07:56
@bernardobelchior
Copy link
Member Author

@noraleonte should we show both tooltips when hovering over the slider track? Currently, we only show the tooltip when hovering over the handle.

@bernardobelchior bernardobelchior marked this pull request as ready for review May 7, 2025 08:54
@TheOneTheOnlyJJ
Copy link

@noraleonte should we show both tooltips when hovering over the slider track? Currently, we only show the tooltip when hovering over the handle.

Could this be controlled through a dedicated prop? It may be desirable to use either one.

@bernardobelchior
Copy link
Member Author

@noraleonte should we show both tooltips when hovering over the slider track? Currently, we only show the tooltip when hovering over the handle.

Could this be controlled through a dedicated prop? It may be desirable to use either one.

We could consider supporting that. Could you describe your use case?

@TheOneTheOnlyJJ
Copy link

We could consider supporting that. Could you describe your use case?

I have not explored any particular use case, but granular control is always a plus if it does not cost too many resources.
I could see this being useful if the range ends could be "fixed" (disabled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants