[charts] Fix infinite tick number when zoom range is zero #17750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
bernardobelchior
added
bug 🐛
|
Deploy preview: https://deploy-preview-17750--material-ui-x.netlify.app/ |
bernardobelchior
commented
May 8, 2025
| @@ -200,7 +200,9 @@ export function computeAxisValue<T extends ChartSeriesType>({ | |||
| } | |||
|
|
|||
| const rawTickNumber = getTickNumber({ ...axis, range, domain: axisExtremums }); | |||
| const tickNumber = rawTickNumber / ((zoomRange[1] - zoomRange[0]) / 100); | |||
| /* If the zoom start and end are the same, `tickNumber` will become infinity, so we should default to 1. */ | |||
| const tickNumber = | |||
There was a problem hiding this comment.
Decided to default to one tick because if zoom range is zero, there is no need to show more than one tick.
There was a problem hiding this comment.
Should we have a test for this? 🤔
CodSpeed Performance ReportMerging #17750 will not alter performanceComparing Summary
|
JCQuintas
approved these changes
May 8, 2025
bernardobelchior
commented
May 9, 2025
| @@ -46,24 +46,6 @@ export interface TickParams { | |||
| tickLabelPlacement?: 'middle' | 'tick'; | |||
| } | |||
|
|
|||
| export function getTickNumber( | |||
JCQuintas
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix infinite tick number when zoom range is zero.
This was causing a crash when the zoom range is zero (i.e., start === end) because d3's
scale.tickscreates anArray(tickNumber)which throws whentickNumberisInfinity.This might happen if the user sets
minSpanto 0 or callssetZoomDatadirectly.