[charts] improve tick rendering performance #17755
Open
+45
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobelchior
added
performance
enhancement
bernardobelchior
force-pushed
the
improve-tick-rendering-perf
branch
2 times, most recently
from
c95783c to
7275f25
Compare
|
Deploy preview: https://deploy-preview-17755--material-ui-x.netlify.app/ |
bernardobelchior
force-pushed
the
improve-tick-rendering-perf
branch
3 times, most recently
from
7d8970a to
70305d9
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
bernardobelchior
force-pushed
the
improve-tick-rendering-perf
branch
from
70305d9 to
d9a86b1
Compare
github-actions
bot
removed
the
PR: out-of-date
bernardobelchior
commented
May 9, 2025
| @@ -44,4 +44,35 @@ describe('ScatterChartPro', () => { | |||
| }, | |||
| options, | |||
| ); | |||
|
|
|||
| bench( | |||
bernardobelchior
requested review from
JCQuintas and
alexfauquette
and removed request for
JCQuintas
JCQuintas
reviewed
May 9, 2025
| for (let i = 0; i < ticks.length; i += 1) { | ||
| const value = ticks[i]; | ||
| const offset = scale(value); | ||
| const point = direction === 'x' ? { x: offset, y: 0 } : { x: 0, y: offset }; |
There was a problem hiding this comment.
the direction in isPointInside handles that for us
Suggested change
| const point = direction === 'x' ? { x: offset, y: 0 } : { x: 0, y: offset }; | |
| const point = { x: offset, y: offset } |
bernardobelchior
force-pushed
the
improve-tick-rendering-perf
branch
from
3e7766e to
20b98ad
Compare
CodSpeed Performance ReportMerging #17755 will improve performances by 9.58%Comparing Summary
Benchmarks breakdown
|
|
CodSpeed doesn't work well with rebases, but according to the PR the benchmark was introduced in, there is a reduction from 7.5s to 71.8ms, a 100x improvement. |
JCQuintas
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve tick rendering performance.
This improvement is especially visible when zooming in because the
tickNumberwould grow to large numbers (> 100k) but most of them would be outside the drawing area. Nevertheless, we were still mapping over all of those and creating a huge array. Now, we iterate over the created ticks but only create the tick object for those that will be inside the drawing area.I think this can be further improved by adjusting the tick number to be slower in the first place.