Skip to content

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Oct 8, 2025

Fix #19754

While looking at having a similar DX to all series type, I noticed the line charts is the only one needing a component outside of the plot component.

For other series, the focus highlight can be done in PieArcPlot, BarPlot, Scatter, and BatchScatter

In this PR the bar charts have the 2 solution implemented to let you see the different options.


Arguments about keeping the focus highlight inside existing component:

  • Pros:
    • Avoid having component computation at multiple places
    • Make sure user will not forget it
  • Cons:
    • Need to introduce inconsistencies between line chart and other charts
    • Devs have a more difficult access to those component (not sure it's a big deal)

Argument in favor of a dedicated component: we could reuse it with visibility: hidden to anchor the tooltip to some node.

@alexfauquette alexfauquette added the scope: charts Changes related to the charts. label Oct 8, 2025
@mui-bot
Copy link

mui-bot commented Oct 8, 2025

Deploy preview: https://deploy-preview-19856--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle size will be reported once CircleCI build #643809 finishes.

Generated by 🚫 dangerJS against c5dfffb

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 13, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: charts Changes related to the charts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[charts] Improve bar chart focus outline

2 participants