-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[scheduler] Improve event popup interactions and toggle behavior #22538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mustafajw07
wants to merge
17
commits into
mui:master
Choose a base branch
from
mustafajw07:feature/21921-Allow-interacting-with-events-and-calendar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
de44e80
[dialog] Implement openEventId management for event dialog interactions
mustafajw07 8774b84
[scheduler][eventDialog] Add openEventId management to SchedulerStore…
mustafajw07 eaf622f
Merge branch 'master' into feature/21921-Allow-interacting-with-event…
mustafajw07 b0c4149
[scheduler][eventDialog] updated EventDialog and test cases
mustafajw07 517b0f3
[scheduler][SchedulerStore] Refactor SchedulerState to include recurr…
mustafajw07 689dfc8
[scheduler][createModal] Enhance modal functionality with imperative …
mustafajw07 3457d1a
refactor(EventDialog): format imports and improve readability of impe…
mustafajw07 15dd7be
[test] Update EventDialog tests to use mouseDown for ClickAwayListene…
mustafajw07 31c1086
Merge branch 'master' into feature/21921-Allow-interacting-with-event…
mustafajw07 a4ce114
Merge branch 'master' into feature/21921-Allow-interacting-with-event…
mustafajw07 fd651ff
Merge branch 'master' into feature/21921-Allow-interacting-with-event…
mustafajw07 6972f29
Merge branch 'master' into feature/21921-Allow-interacting-with-event…
mustafajw07 df990f1
Merge branch 'master' into feature/21921-Allow-interacting-with-event…
mustafajw07 f4cb40b
Merge branch 'master' into feature/21921-Allow-interacting-with-event…
mustafajw07 cb15dc0
Merge branch 'master' into feature/21921-Allow-interacting-with-event…
mustafajw07 2d28094
[fix] Update ClickAwayListener mouse event to 'onClick' for correct b…
mustafajw07 3e61437
[fix] Update ClickAwayListener interaction to use 'onClick' for closi…
mustafajw07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to only change the store state but doesn't open the dialog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve updated the implementation to ensure the dialog open state is handled correctly alongside the selected event state.