[charts] Add seriesId prop to MapShapePlot#22975
Closed
JCQuintas wants to merge 1 commit into
Closed
Conversation
Allows rendering a subset of `mapShape` series, so multiple `MapShapePlot` can style separate layers (for example filled shapes below and outlines on top).
Member
Author
|
@alexfauquette Not sure if we want to keep the current behaviour or force one |
Deploy previewhttps://deploy-preview-22975--material-ui-x.netlify.app/ Bundle size
PerformanceTotal duration: 2,019.49 ms +157.38 ms(+8.5%) | Renders: 63 (+0)
…and 4 more (+17 within noise) — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
Member
|
Not sure to get it. why not using the |
Member
Author
For some reason I though our default API was using multiple plots 🫠 nvm, it seems I need a cup of coffee... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
seriesIdprop toMapShapePlotto render only a subset ofmapShapeseries.Until now
MapShapePlotalways rendered everymapShapeseries, and itsfill/stroke/strokeWidthapply uniformly. That made it impossible to style separate layers differently. WithseriesId, multipleMapShapePlotcan each target their own series — for example filled shapes below and outlines on top.seriesIdaccepts a single id or an array of ids.mapShapeseries).The underlying
useMapShapeSerieshook already supports id filtering; this exposes it through the component.A docs example using this prop follows in a separate PR.