Skip to content

[CRUD] Use links in ID cell instead of onRowClick #4943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented May 15, 2025

Closes #4825

Uses renderCell to make the id column in CRUD List pages work as a link.
Changes component props accordingly, as onRowClick is not needed or used anymore.

Screen.Recording.2025-05-15.at.18.50.54.mov

https://deploy-preview-4943--mui-toolpad-docs.netlify.app/toolpad/core/react-crud/
https://deploy-preview-4943--mui-toolpad-docs.netlify.app/toolpad/core/react-crud/#list-component

@apedroferreira apedroferreira self-assigned this May 15, 2025
@apedroferreira apedroferreira added enhancement This is not a bug, nor a new feature scope: toolpad-core Abbreviated to "core" component: crud labels May 15, 2025
@mui-bot
Copy link

mui-bot commented May 15, 2025

Netlify deploy preview

https://deploy-preview-4943--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 842dd9b

@apedroferreira apedroferreira marked this pull request as draft May 15, 2025 18:05
@apedroferreira apedroferreira marked this pull request as ready for review May 20, 2025 10:19
@apedroferreira apedroferreira requested a review from a team May 20, 2025 10:22
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: crud enhancement This is not a bug, nor a new feature PR: out-of-date The pull request has merge conflicts and can't be merged scope: toolpad-core Abbreviated to "core"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRUD] Fix accessibility of rows in Crud component
2 participants