Skip to content

Commit 574b6a6

Browse files
committed
Merge branch 'notify-app-ios-on-successful-nightly-test-runs-ios-1575'
2 parents 2a608f1 + a95fb52 commit 574b6a6

2 files changed

Lines changed: 4 additions & 16 deletions

File tree

.github/workflows/ios-end-to-end-tests-nightly-notification.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ jobs:
1313
notify-on-failed-workflow:
1414
# Payload of workflow_run:
1515
# https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2026-03-10#get-a-workflow-run
16-
if: "${{ github.event.workflow_run.conclusion != 'successful' }}"
16+
#
17+
# Valid values for conclusion are listed on:
18+
# https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks#check-statuses-and-conclusions
19+
if: "${{ github.event.workflow_run.conclusion != 'success' }}"
1720
name: Notify team on nightly E2E failure
1821
runs-on: [ubuntu-latest]
1922
timeout-minutes: 5

.github/workflows/ios-end-to-end-tests-nightly.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,3 @@ jobs:
2222
with:
2323
arg_tests_json_key: "nightly"
2424
secrets: inherit
25-
26-
notify-on-failure:
27-
if: failure()
28-
name: Notify team on nightly E2E failure
29-
runs-on: [self-hosted, macOS, ios-test]
30-
needs: reuse-e2e-workflow
31-
timeout-minutes: 5
32-
steps:
33-
- name: Send custom event details to a Slack workflow
34-
uses: slackapi/slack-github-action@v2.1.1
35-
with:
36-
webhook: ${{ secrets.IOS_SLACK_WEBHOOK_URL }}
37-
webhook-type: webhook-trigger
38-
payload: |
39-
run_url: "https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

0 commit comments

Comments
 (0)