Add carousel slides to multihop settings view#10207
Draft
Conversation
|
🚨 End to end tests failed. Please check the failed workflow run. |
rablador
force-pushed
the
implement-carousel-slides-in-multihop-settings-view-ios-1565
branch
3 times, most recently
from
8064009 to
d294d04
Compare
rablador
force-pushed
the
implement-carousel-slides-in-multihop-settings-view-ios-1565
branch
from
d294d04 to
18476d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this needs to be done
Even though the new multihop settings are easier to understand at a glance due to their naming, we'd like to show examples of each mode as well
How do we implement this feature?
Add the carousel we use for FAA and DAITA with the corresponding multihop illustrations and texts. The texts shall not contain any links or special difficult to implement things.
Acceptance criteria
Users get a page to read for each multihop setting + one general page
Testing
We should ensure that e2e tests still work with these changes applied. We should update the expected number of pages in the UI tests.
This change is