Conversation
|
The report a problem view is not scrollable anymore it seems... The "View app logs" button seems very squished. 👀 I don't know if it's new with this PR or not. 
|
mullmat
left a comment
mullmat
left a comment
There was a problem hiding this comment.
Outside of the comments:
In Server IP overrides, in the text import the "Import" text button is disabled, do we want to also enable it and have an empty state error message toast?
@mullmat made 5 comments.
Reviewable status: 0 of 21 files reviewed, 4 unresolved discussions (waiting on Pururun).
android/lib/feature/anticensorship/impl/src/main/java/net/mullvad/mullvadvpn/feature/anticensorship/impl/customport/CustomPortDialog.kt line 0 at r1 (raw file):
No empty state error message?
android/lib/feature/redeemvoucher/impl/src/main/java/net/mullvad/mullvadvpn/feature/redeemvoucher/impl/RedeemVoucherDialog.kt line 0 at r1 (raw file):
No specific error message for the voucher dialog, currently it only says "Voucher code is invalid" even if the inputfield is empty.
Perhaps something similar to the other empty error messages?
android/lib/feature/vpnsettings/impl/src/main/kotlin/net/mullvad/mullvadvpn/feature/vpnsettings/impl/dns/DnsDialog.kt line 0 at r1 (raw file):
No empty state error message?
android/lib/feature/vpnsettings/impl/src/main/kotlin/net/mullvad/mullvadvpn/feature/vpnsettings/impl/mtu/MtuDialog.kt line 0 at r1 (raw file):
No empty state error message?
Should be fixed in #10264 |
Pururun
force-pushed
the
enable-all-buttons-and-use-error-messages-instead-droid-2559
branch
from
d82326d to
d8ba0a3
Compare
Pururun
left a comment
Pururun
left a comment
There was a problem hiding this comment.
@Pururun made 4 comments.
Reviewable status: 0 of 33 files reviewed, 4 unresolved discussions (waiting on mullmat).
android/lib/feature/anticensorship/impl/src/main/java/net/mullvad/mullvadvpn/feature/anticensorship/impl/customport/CustomPortDialog.kt line at r1 (raw file):
Previously, mullmat (MullMat) wrote…
No empty state error message?
Done.
android/lib/feature/redeemvoucher/impl/src/main/java/net/mullvad/mullvadvpn/feature/redeemvoucher/impl/RedeemVoucherDialog.kt line at r1 (raw file):
Previously, mullmat (MullMat) wrote…
No specific error message for the voucher dialog, currently it only says "Voucher code is invalid" even if the inputfield is empty.
Perhaps something similar to the other empty error messages?
Done.
android/lib/feature/vpnsettings/impl/src/main/kotlin/net/mullvad/mullvadvpn/feature/vpnsettings/impl/dns/DnsDialog.kt line at r1 (raw file):
Previously, mullmat (MullMat) wrote…
No empty state error message?
Done.
android/lib/feature/vpnsettings/impl/src/main/kotlin/net/mullvad/mullvadvpn/feature/vpnsettings/impl/mtu/MtuDialog.kt line at r1 (raw file):
Previously, mullmat (MullMat) wrote…
No empty state error message?
Done.
Pururun
force-pushed
the
enable-all-buttons-and-use-error-messages-instead-droid-2559
branch
2 times, most recently
from
04b0961 to
3f49e60
Compare
Pururun
force-pushed
the
enable-all-buttons-and-use-error-messages-instead-droid-2559
branch
from
3f49e60 to
250650c
Compare
2 participants
This change is