Skip to content

Add a floating search bar#10286

Open
pinkisemils wants to merge 4 commits intomainfrom
implement-floating-search-field-ios-1353
Open

Add a floating search bar#10286
pinkisemils wants to merge 4 commits intomainfrom
implement-floating-search-field-ios-1353

Conversation

@pinkisemils
Copy link
Copy Markdown
Collaborator

@pinkisemils pinkisemils commented Apr 24, 2026

Adding a floating search bar at the bottom.


This change is Reviewable

@pinkisemils pinkisemils added the iOS Issues related to iOS label Apr 24, 2026
@linear
Copy link
Copy Markdown

linear Bot commented Apr 24, 2026

@github-actions
Copy link
Copy Markdown

🚨 End to end tests failed. Please check the failed workflow run.

@pinkisemils pinkisemils force-pushed the implement-floating-search-field-ios-1353 branch from b963301 to a82e1d0 Compare April 24, 2026 08:55
@waahlnaden
Copy link
Copy Markdown
Collaborator

I am having some lag at first launch / usage.

A behavioural change I'd like is that when you press return with an empty field to cancel searching, the field should ideally collapse into its initial state.

Another would be that when picking an entry from searching, it should probably collapse as well - as you'd probably not pick the same exit. However, this is a tough one; maybe users prefer multihoping within one country / location? To be discussed

Copy link
Copy Markdown
Collaborator Author

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will now dismiss the search field. We could add another X icon in the search field to quickly remove the current term - this will allow users to quickly reset search whilst letting users select both entry and exit from the same search results.

@pinkisemils made 1 comment.
Reviewable status: 0 of 7 files reviewed, all discussions resolved.

@waahlnaden
Copy link
Copy Markdown
Collaborator

carlfixes.txt

Some styling updates diffs

@waahlnaden
Copy link
Copy Markdown
Collaborator

It will now dismiss the search field. We could add another X icon in the search field to quickly remove the current term - this will allow users to quickly reset search whilst letting users select both entry and exit from the same search results.

@pinkisemils made 1 comment.
Reviewable status: 0 of 7 files reviewed, all discussions resolved.

Yes, we should add that. I will add it to the component

Copy link
Copy Markdown
Collaborator Author

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied your fixes too and now we have a button to clear the text.

@pinkisemils made 1 comment.
Reviewable status: 0 of 7 files reviewed, all discussions resolved.

@github-actions
Copy link
Copy Markdown

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iOS Issues related to iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants