Conversation
dlon
approved these changes
Sep 12, 2025
Member
dlon
left a comment
There was a problem hiding this comment.
@dlon reviewed 18 of 18 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
src/transaction.rs line 1 at r2 (raw file):
// Copyright 2024 Mullvad VPN AB.
Nit: We should update these
hulthe
commented
Sep 12, 2025
Contributor
Author
hulthe
left a comment
There was a problem hiding this comment.
Reviewable status: 7 of 35 files reviewed, all discussions resolved (waiting on @dlon)
src/transaction.rs line 1 at r2 (raw file):
Previously, dlon (David Lönnhager) wrote…
Nit: We should update these
Done
dlon
approved these changes
Sep 12, 2025
Member
dlon
left a comment
There was a problem hiding this comment.
@dlon reviewed 28 of 28 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is