Improve verify function API slightly - #13
Merged
Merged
Conversation
faern
force-pushed
the
improve-verify-function-api
branch
from
February 4, 2026 13:25
a7ae8d8 to
8110d30
Compare
gregoire-mullvad
force-pushed
the
improve-verify-function-api
branch
from
February 4, 2026 15:12
86818a1 to
8110d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
verifyfunction more idiomatic and a bit easier to use. Take arguments by reference instead of ownership where it makes sense.