Skip to content

Add built-in policies - #7

Merged
gregoire-mullvad merged 1 commit into
mainfrom
built-policies
Dec 23, 2025
Merged

Add built-in policies#7
gregoire-mullvad merged 1 commit into
mainfrom
built-policies

Conversation

@gregoire-mullvad

Copy link
Copy Markdown
Member

This PR should be merged after #6

Comment thread src/policy/builtin.rs Outdated
const SIGSUM_TEST1_2025: &str = include_str!("sigsum-test1-2025.builtin-policy");
const SIGSUM_TEST2_2025: &str = include_str!("sigsum-test1-2025.builtin-policy");
const SIGSUM_TEST_2025_3: &str = include_str!("sigsum-test1-2025.builtin-policy");
const SIGSUM_GENERAL_2025_1: &str = include_str!("sigsum-test1-2025.builtin-policy");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all include the same file

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed 🤦. Should be fixed now!

Comment thread src/policy/builtin.rs Outdated
const SIGSUM_TEST1_2025: &str = include_str!("sigsum-test1-2025.builtin-policy");
const SIGSUM_TEST2_2025: &str = include_str!("sigsum-test1-2025.builtin-policy");
const SIGSUM_TEST_2025_3: &str = include_str!("sigsum-test1-2025.builtin-policy");
const SIGSUM_GENERAL_2025_1: &str = include_str!("sigsum-test1-2025.builtin-policy");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is called generic in the file but general in the code

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@Jontified Jontified left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from policy-parsing to main December 23, 2025 09:37
@gregoire-mullvad
gregoire-mullvad merged commit b43f805 into main Dec 23, 2025
20 checks passed
@gregoire-mullvad
gregoire-mullvad deleted the built-policies branch December 23, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants