Skip to content

Fix chat priority starvation under high load #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zephkek wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Fix chat priority starvation under high load #4890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Server/mods/deathmatch/logic/packets/CChatClearPacket.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ class CChatClearPacket final : public CPacket
public:
CChatClearPacket() {};

// Chat uses low priority channel to avoid getting queued behind large map downloads #6877
// Keep chat on its own ordered channel, but avoid low-priority starvation under heavy sync load.
ePacketID GetPacketID() const { return PACKET_ID_CHAT_CLEAR; };
unsigned long GetFlags() const { return PACKET_LOW_PRIORITY | PACKET_RELIABLE | PACKET_SEQUENCED; };
unsigned long GetFlags() const { return PACKET_MEDIUM_PRIORITY | PACKET_RELIABLE | PACKET_SEQUENCED; };
virtual ePacketOrdering GetPacketOrdering() const { return PACKET_ORDERING_CHAT; }

bool Write(NetBitStreamInterface& BitStream) const;
Expand Down
4 changes: 2 additions & 2 deletions Server/mods/deathmatch/logic/packets/CChatEchoPacket.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ class CChatEchoPacket final : public CPacket
m_ucMessageType = ucMessageType;
};

// Chat uses low priority channel to avoid getting queued behind large map downloads #6877
// Keep chat on its own ordered channel, but avoid low-priority starvation under heavy sync load.
ePacketID GetPacketID() const { return PACKET_ID_CHAT_ECHO; };
unsigned long GetFlags() const { return PACKET_LOW_PRIORITY | PACKET_RELIABLE | PACKET_SEQUENCED; };
unsigned long GetFlags() const { return PACKET_MEDIUM_PRIORITY | PACKET_RELIABLE | PACKET_SEQUENCED; };
virtual ePacketOrdering GetPacketOrdering() const { return PACKET_ORDERING_CHAT; }

bool Write(NetBitStreamInterface& BitStream) const;
Expand Down
Loading