Reliability fixes for nickname valid-checks on client and server#4909
Merged
Dutchman101 merged 2 commits intomultitheftauto:masterfrom May 9, 2026
Merged
Reliability fixes for nickname valid-checks on client and server#4909Dutchman101 merged 2 commits intomultitheftauto:masterfrom
Dutchman101 merged 2 commits intomultitheftauto:masterfrom
Conversation
sbx320
previously approved these changes
May 9, 2026
sbx320
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reliability fixes for nickname valid-checks on client and server
Fix 1: Backtick validation gap (client)
Added strchr(szNick, '') != nullptrcheck to the client's CheckNickProvided, matching the server's version in Shared/Utils.cpp. Previously, a nickname containing a backtick passed all client-side checks, was serialized correctly, and then got rejected server-side with INVALID_NICKNAME.
Fix 2: Unchecked ReadString (server)
Added return-value check on BitStream.ReadString(m_strPlayerVersion). If this read fails (corrupted length prefix from a shifted bitstream), it now returns false immediately instead of continung to parse the nickname and subsequent fields from a wrong offset. This prevents garbage data from being interpreted as the nickname and triggering an incorrect INVALID_NICKNAME.