En 13550: address generator#153
Open
dragos-rebegea wants to merge 2 commits intofeat/freeze-accountfrom
Open
Conversation
AdoAdoAdo
approved these changes
Jan 13, 2023
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an address generator system for creating new addresses based on creator address, nonce, and VM type. The address generator uses keccak256 hashing to create addresses with specific prefix and suffix masks.
- Implements core address generation functionality with proper validation and error handling
- Adds mock stub for testing purposes
- Updates project dependencies to newer versions
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates dependency versions for gorilla/websocket, stretchr/testify, protobuf, and yaml |
| core/mock/addressGeneratorStub.go | Mock implementation of AddressGenerator interface for testing |
| core/addressGenerator/errors.go | Error definitions for address and VM type length validation |
| core/addressGenerator/addressGenerator_test.go | Comprehensive test suite for address generation functionality |
| core/addressGenerator/addressGenerator.go | Main address generator implementation with validation and hashing logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| buffNonce := make([]byte, 8) | ||
| binary.LittleEndian.PutUint64(buffNonce, creatorNonce) | ||
| adrAndNonce := append(creatorAddress, buffNonce...) | ||
| scAddress := keccak.NewKeccak().Compute(string(adrAndNonce)) |
There was a problem hiding this comment.
Creating a new keccak hasher instance here instead of using the instance stored in ag.hasher field is inefficient and inconsistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.