Updated GasScheduleNotifier interface#314
Open
sstanculeanu wants to merge 1 commit intorc/v1.7.next1from
Open
Conversation
andreibancioiu
approved these changes
Aug 9, 2024
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the GasScheduleNotifier interface to support fetching the gas schedule for a specific epoch.
- Added a new method
GasScheduleForEpochto the interface.
Comments suppressed due to low confidence (2)
core/interface.go:103
- Add a Go-style doc comment above
GasScheduleForEpochexplaining its purpose, parameters, return values, and error conditions.
GasScheduleForEpoch(epoch uint32) (map[string]map[string]uint64, error)
core/interface.go:103
- Ensure there are corresponding unit tests covering
GasScheduleForEpoch, including valid epochs, boundary conditions, and error paths.
GasScheduleForEpoch(epoch uint32) (map[string]map[string]uint64, error)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.