Skip to content

Fix transaction fields #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miiu96 merged 2 commits into from
Nov 27, 2025
Merged

Fix transaction fields #356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d198b4
fix
miiu96 Nov 27, 2025
dd76781
integration test
miiu96 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
github.com/multiversx/mx-chain-communication-go v1.3.0
github.com/multiversx/mx-chain-core-go v1.4.0
github.com/multiversx/mx-chain-logger-go v1.1.0
github.com/multiversx/mx-chain-vm-common-go v1.6.0
github.com/multiversx/mx-chain-vm-common-go v1.6.1-0.20251127112501-0b5f28e33b2e
github.com/prometheus/client_model v0.6.1
github.com/prometheus/common v0.62.0
github.com/stretchr/testify v1.10.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ github.com/multiversx/mx-chain-crypto-go v1.3.0 h1:0eK2bkDOMi8VbSPrB1/vGJSYT81IB
github.com/multiversx/mx-chain-crypto-go v1.3.0/go.mod h1:nPIkxxzyTP8IquWKds+22Q2OJ9W7LtusC7cAosz7ojM=
github.com/multiversx/mx-chain-logger-go v1.1.0 h1:97x84A6L4RfCa6YOx1HpAFxZp1cf/WI0Qh112whgZNM=
github.com/multiversx/mx-chain-logger-go v1.1.0/go.mod h1:K9XgiohLwOsNACETMNL0LItJMREuEvTH6NsoXWXWg7g=
github.com/multiversx/mx-chain-vm-common-go v1.6.0 h1:M2zmf/ptEINciWxYCPLIkwOMTvvzWjELYYB+0MMQ5Gw=
github.com/multiversx/mx-chain-vm-common-go v1.6.0/go.mod h1:Lc7r4VDPYRDS0CVIaWAoLtf3YQn6PZEYHv4QtaOE2Z0=
github.com/multiversx/mx-chain-vm-common-go v1.6.1-0.20251127112501-0b5f28e33b2e h1:3gboKT4hPEb9ZkAYO2Z/y3sOaUBzxVMN4FhyLFcRSHI=
github.com/multiversx/mx-chain-vm-common-go v1.6.1-0.20251127112501-0b5f28e33b2e/go.mod h1:Lc7r4VDPYRDS0CVIaWAoLtf3YQn6PZEYHv4QtaOE2Z0=
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
github.com/nxadm/tail v1.4.4/go.mod h1:kenIhsEOeOJmVchQTgglprH7qJGnHDVpk1VPCcaMI8A=
Expand Down
2 changes: 1 addition & 1 deletion process/elasticproc/transactions/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

// DataFieldParser defines what a data field parser should be able to do
type DataFieldParser interface {
Parse(dataField []byte, sender, receiver []byte, numOfShards uint32) *datafield.ResponseParseData
Parse(dataField []byte, sender, receiver []byte, numOfShards uint32, epoch uint32) *datafield.ResponseParseData
}

type feeInfoHandler interface {
Expand Down
2 changes: 1 addition & 1 deletion process/elasticproc/transactions/smartContractResultsProcessor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func (proc *smartContractResultsProcessor) prepareSmartContractResult(
originalSenderAddr = proc.pubKeyConverter.SilentEncode(scr.OriginalSender, log)
}

res := proc.dataFieldParser.Parse(scr.Data, scr.SndAddr, scr.RcvAddr, numOfShards)
res := proc.dataFieldParser.Parse(scr.Data, scr.SndAddr, scr.RcvAddr, numOfShards, header.GetEpoch())

senderAddr := proc.pubKeyConverter.SilentEncode(scr.SndAddr, log)
receiverAddr := proc.pubKeyConverter.SilentEncode(scr.RcvAddr, log)
Expand Down
2 changes: 1 addition & 1 deletion process/elasticproc/transactions/transactionDBBuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func (dtb *dbTransactionBuilder) prepareTransaction(
tx := txInfo.Transaction

isScCall := core.IsSmartContractAddress(tx.RcvAddr)
res := dtb.dataFieldParser.Parse(tx.Data, tx.SndAddr, tx.RcvAddr, numOfShards)
res := dtb.dataFieldParser.Parse(tx.Data, tx.SndAddr, tx.RcvAddr, numOfShards, header.GetEpoch())

receiverAddr := dtb.addressPubkeyConverter.SilentEncode(tx.RcvAddr, log)
senderAddr := dtb.addressPubkeyConverter.SilentEncode(tx.SndAddr, log)
Expand Down
5 changes: 3 additions & 2 deletions process/elasticproc/transactions/transactionsProcessor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ func NewTransactionsProcessor(args *ArgsTransactionProcessor) (*txsDatabaseProce
}

argsParser := &datafield.ArgsOperationDataFieldParser{
AddressLength: args.AddressPubkeyConverter.Len(),
Marshalizer: args.Marshalizer,
AddressLength: args.AddressPubkeyConverter.Len(),
Marshalizer: args.Marshalizer,
RelayedTransactionsV1V2DisableEpoch: args.EnableEpochsConfig.RelayedTransactionsV1V2DisableEpoch,
}
operationsDataParser, err := datafield.NewOperationDataFieldParser(argsParser)
if err != nil {
Expand Down
Loading