Skip signer indices indexing#6862
Merged
sstanculeanu merged 16 commits intofeat/andromeda-fixesfrom Mar 12, 2025
Merged
Conversation
AdoAdoAdo
reviewed
Mar 7, 2025
| } | ||
|
|
||
| signersIndexes, err := sr.NodesCoordinator().GetValidatorsIndexes(pubKeys, epoch) | ||
| signersIndexes := make([]uint64, 0) |
Contributor
There was a problem hiding this comment.
I think the flag check can be removed from here, as the /v2/subroundStartRound.go will be used for Equivalent messages, and /v1/subroundStartRound.go otherwise
|
|
||
| signersIndexes, err := sr.NodesCoordinator().GetValidatorsIndexes(pubKeys, epoch) | ||
| signersIndexes := make([]uint64, 0) | ||
| if !sr.EnableEpochsHandler().IsFlagEnabled(common.EquivalentMessagesFlag) { |
Contributor
There was a problem hiding this comment.
I think this can be removed from here, as the /v2/subroundStartRound.go will be used for Equivalent messages, and /v1/subroundStartRound.go otherwise
|
|
||
| signersIndexes := make([]uint64, 0) | ||
| // when EquivalentMessages flag is enabled signer indices can be empty because all validators are in consensus group | ||
| if odp.enableEpochsHandler.IsFlagEnabled(common.EquivalentMessagesFlag) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if odp.enableEpochsHandler.IsFlagEnabled(common.EquivalentMessagesFlag) { | |
| if odp.enableEpochsHandler.IsFlagEnabledInEpoch(common.EquivalentMessagesFlag, header.GetEpoch()) { |
AdoAdoAdo
previously approved these changes
Mar 10, 2025
sstanculeanu
previously approved these changes
Mar 11, 2025
AdoAdoAdo
previously approved these changes
Mar 11, 2025
# Conflicts: # go.mod # go.sum
AdoAdoAdo
approved these changes
Mar 12, 2025
sstanculeanu
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
leaderIndexandleaderBlsKeysignerIndicesfield whenEquivalentMessageflag is active ( we no longer need to put this field inOutportBlockbecause all validators are in the consensus group for every block)Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?