Refactored pagination component

[iuliacimpeanu]

Turn Pagination component into function and stop exporting webcomponent

[gemini-code-assist]

Summary of Changes

Hello @iuliacimpeanu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring of the pagination component, transitioning it from a Stencil class-based implementation to a more modern and flexible functional component. This change aims to improve the component's maintainability and integration across the application, particularly within the AddressTable component, which has been updated to consume the new functional pagination. Additionally, the MvxTransactionsTable component now supports a pageChange event, enhancing its interactive capabilities.

Highlights

• Pagination Component Refactoring: The mvx-pagination component has been refactored from a Stencil class-based component into a functional component named Pagination. This change streamlines its implementation and enhances reusability.
• Component Definition Updates: The src/components.d.ts file has been updated to remove the old MvxPagination interface and related event maps, reflecting the removal of the class-based component. It also adds MvxTransactionsTableCustomEvent and updates HTMLMvxTransactionsTableElement to include event listeners for a pageChange event.
• Integration in AddressTable: The AddressTable component (src/components/visual/address-table/address-table.tsx) has been updated to import and utilize the new functional Pagination component. This includes adapting to the new prop-based event handling for page changes and managing tooltip state internally.
• Storybook Updates: The Storybook configuration for the pagination component (src/components/visual/pagination/pagination.stories.tsx) has been adjusted to correctly type and render the new functional Pagination component.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully refactors the Pagination component from a Stencil class-based web component to a stateless, controlled functional component. This is a great improvement for maintainability and aligns with modern frontend practices by making it a controlled component. The state is now correctly managed by parent components like AddressTable. The changes are well-contained and the logic has been preserved correctly. I've found one issue in the Storybook file that needs to be addressed, and another suggestion for improving code organization.