Conversation
* Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review
* Eslint fixes * Prettierrc fixes * Updated changelog
* Added min/max toasts * Update changelog * Replace icon
* Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com>
* Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review
* Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review
* Fixed copy button * Upgraded version
* 0.1.5 (#275) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com> * Updated changelog --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com>
* Updated package version * Updated changelog * Updated lockfile
* Refactored pagination comp * Refactored pagination ellipsis * Work on pagination * Refactor components * Work on pagination * Fixed pagination story * Move pagination to address-table * Update CHANGELOG * Try fix tests * Remove log * Remove unused contentclass * Remove logs * Minor edits * /gemini review --------- Co-authored-by: Tudor Morar <tudor.morar@multiversx.com>
* 0.1.7 (#281) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version * Fixed copy button (#276) * Fixed copy button * Upgraded version * Sync development with main (#278) * 0.1.5 (#275) * Refactored sign transactions panel internal components (#267) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Fixed test * Updated changelog * Updated files * Fixes after review * Eslint and prettierrc fixes (#270) * Eslint fixes * Prettierrc fixes * Updated changelog * Added minimize/maximize toasts (#272) * Added min/max toasts * Update changelog * Replace icon * Fixed trimmed address not showing in address-table (#273) * Fixed addresses not showing * Fix issue with trimWrapperVisible * Fixed unlockPanelFooter styles * Updated Trim * Updated Trim * Updated changelog --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com> * Refactored side panel components (#271) * Update styles * Refactored sign transactions footer * Refactored copy button * Refactored button component * Refactored tooltip component * Refactored spinner icon component * Refactored arrow right component * Updated copy button * Updated styles * Refactored sign transactions overview * Refactored sign-transactions-advanced and sign-transactions-header * Updated styles * Updated styles * Fixed test * Updated changelog * Updated changelog * Updated files * Fixes after review * Fixes after review * Updates files location * Refactored side-panel-header comp * Refactored side-panel comp * Refactored side-panel-swipper styles * Refactored side panel swiper component. * Updated components * Updated styles * Updated changelog * Fixed test * Fixes after review * Refactored transaction list item (#274) * Refactored styles * Refactored transaction-list-item component * Updated changelog * Fixed tests * Fixes after review * Upgraded version --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com> * Updated changelog --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com> * Fixed compatibility issue on stencil/core (#279) * Updated package version * Updated changelog * Updated lockfile * Upgraded version --------- Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com> Co-authored-by: Tudor Morar <tudor.morar@multiversx.com> * v0.1.8 (#283) - fix SidePanel WalletConnect issues - (temp) fix sdk-dapp 5.5.1 breaking changes - update publish script - pnpm test fix * Add provider selection handling to unlock panel - Subscribed to SELECT_PROVIDER event to handle provider selection. - Implemented handleProviderSelection method to initiate login with the selected provider. - Updated unsubscribe functions to include the new subscription. * Update CHANGELOG * Update CHANGELOG * Update version --------- Co-authored-by: Iulia Cimpeanu <72752718+iuliacimpeanu@users.noreply.github.com> Co-authored-by: Gavrila Andrei <andrei.gavrila@multiversx.com> Co-authored-by: Radu Mojic <radu.mojic@multiversx.com>
Summary of ChangesHello @arhtudormorar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring and enhancement of the UI component library. It centralizes common components into a dedicated 'common' directory, streamlines the transaction list item's location, and completely revamps the pagination system for improved functionality and maintainability. These changes aim to create a more modular and robust UI foundation, while also introducing new features like explicit provider selection in the unlock flow. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the version to 0.1.9 and includes several refactorings and fixes. The SidePanel and TransactionListItem components have been moved to new locations for better organization. The mvx-pagination web component has been removed and replaced with a functional component within the address-table, which is a good improvement. The ANIMATION_DELAY_PROMISE has been correctly changed to a function to avoid issues with promise reuse.
My review includes a correction for a duplicated entry in the CHANGELOG.md and a suggestion to improve maintainability by renaming a file with a misleading name. Overall, the changes are positive and improve the codebase.
|
|
||
| ## [[0.1.6](https://github.com/multiversx/mx-sdk-dapp-ui/pull/277)] - 2025-12-09 | ||
|
|
| @Component({ | ||
| tag: 'mvx-pagination', | ||
| styleUrl: 'pagination.scss', | ||
| shadow: true, | ||
| }) |
There was a problem hiding this comment.
The filename pagination-story.tsx is misleading as this file defines a Stencil component (@Component({ tag: 'mvx-pagination' ... })), not a Storybook story. This could cause confusion for future maintenance. Consider renaming it to something like pagination.component.tsx or pagination.tsx to better reflect its content.
No description provided.