Refactor get animation delay

[arhtudormorar]

Refactored side panel helper ANIMATION_DELAY_PROMISE to getAnimationDelay

[gemini-code-assist]

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the organization and clarity of the codebase by refactoring a specific utility function. The change involves relocating the animation delay logic from a general constants file into its own dedicated helper module, which enhances modularity and makes the function's purpose more explicit. This refactoring does not alter the functionality or behavior of the animation delay.

Highlights

• Code Refactoring: The ANIMATION_DELAY_PROMISE constant has been refactored into a dedicated helper function named getAnimationDelay.
• File Structure Update: The animation delay logic has been moved from src/common/SidePanel/sidePanel.constants.ts to a new file: src/common/SidePanel/helpers/getAnimationDelay.ts.
• Usage Updates: All instances where ANIMATION_DELAY_PROMISE was used (in notifications-feed.tsx, pending-transactions-panel.tsx, sign-transactions-panel.tsx, and unlock-panel.tsx) have been updated to import and use the new getAnimationDelay function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the ANIMATION_DELAY_PROMISE into a more aptly named function getAnimationDelay and moves it to a dedicated helper file. The changes are applied consistently across several components. My review includes suggestions to improve the code further by extracting a magic number into a constant for better maintainability, and simplifying async function returns for conciseness. Overall, this is a good refactoring that improves code clarity.

[gemini-code-assist]

To improve readability and maintainability, it's best to avoid magic numbers. Please extract 300 into a named constant. This makes the code self-documenting and easier to update in the future.

Suggested change

	export const getAnimationDelay = () => new Promise(resolve => setTimeout(resolve, 300));
	export const ANIMATION_DELAY_MS = 300;
	export const getAnimationDelay = () => new Promise(resolve => setTimeout(resolve, ANIMATION_DELAY_MS));

[gemini-code-assist]

Since closeWithAnimation is an async function, you can directly return the promise from getAnimationDelay(). This simplifies the code.

Suggested change

	const animationDelay = await getAnimationDelay();
	return animationDelay;
	return getAnimationDelay();

[gemini-code-assist]

Since closeWithAnimation is an async function, you can directly return the promise from getAnimationDelay(). This simplifies the code.

Suggested change

	const animationDelay = await getAnimationDelay();
	return animationDelay;
	return getAnimationDelay();

[gemini-code-assist]

Since closeWithAnimation is an async function, you can directly return the promise from getAnimationDelay(). This simplifies the code.

Suggested change

	const animationDelay = await getAnimationDelay();
	return animationDelay;
	return getAnimationDelay();

[gemini-code-assist]

Since closeWithAnimation is an async function, you can directly return the promise from getAnimationDelay(). This simplifies the code.

Suggested change

	const animationDelay = await getAnimationDelay();
	return animationDelay;
	return getAnimationDelay();