Conversation
Summary of ChangesHello @arhtudormorar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a version increment and a structural refactoring within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the package version to 0.1.15 and updates the exports for some helper functions. My review has identified a few points for consideration:
- A minor typo in
CHANGELOG.md. - A potentially breaking change in
package.jsonwhere export paths have been altered in a patch release. This could impact users of the library. - A potentially redundant file path in
tsconfig.utils.jsonwhich could be a leftover from refactoring.
Please see the detailed comments for suggestions.
CHANGELOG.md
Outdated
| ## [[0.1.15](https://github.com/multiversx/mx-sdk-dapp-ui/pull/296)] - 2026-01-26 | ||
|
|
||
| - [Fixed emit page value when page changes (tm/fix/emit-page-value → development)](https://github.com/multiversx/mx-sdk-dapp-ui/pull/295) | ||
| - [Fixed helpers export)](https://github.com/multiversx/mx-sdk-dapp-ui/pull/296) |
There was a problem hiding this comment.
tsconfig.utils.json
Outdated
| "src/components/functional/unlock-panel/helpers/getIsExtensionAvailable.ts", | ||
| "src/utils/helpers/getIsExtensionAvailable.ts", |
There was a problem hiding this comment.
The file src/utils/helpers/getIsExtensionAvailable.ts is included here, but it seems redundant. The package.json exports for getIsExtensionAvailable now point to the file located at src/components/functional/unlock-panel/helpers/getIsExtensionAvailable.ts (included on the line above).
If src/utils/helpers/getIsExtensionAvailable.ts was moved or is no longer used, this entry should be removed to keep the build configuration clean. This suggestion removes the redundant line and the trailing comma from the previous line.
"src/components/functional/unlock-panel/helpers/getIsExtensionAvailable.ts"
No description provided.