Data tesids

[arhtudormorar]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the testability of UI components by introducing and refining data-testid attributes. It includes adding a new data-testid for the side panel's close button and adjusting how data-testids are applied to the Button component to ensure proper and non-redundant implementation. These changes are accompanied by a version increment and an update to the project's changelog.

Highlights

• Version Update: The project version has been incremented from 0.1.19 to 0.1.20 in package.json and reflected in CHANGELOG.md.
• Data Test ID Enhancement: A new data-testid (sidePanelCloseButton) has been introduced and applied to the close button in the SidePanelHeader component for improved testability.
• Button Component Refinement: The handleClick method in the Button component was marked as readonly, and a redundant data-testid assignment was commented out, clarifying that it's handled via a prop.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• CHANGELOG.md
  • Added an entry for version 0.1.20, noting fixes to data-testids.
• package.json
  • Updated the package version from 0.1.19 to 0.1.20.
• src/common/SidePanel/components/SidePanelHeader/SidePanelHeader.tsx
  • Imported DataTestIdsEnum and assigned sidePanelCloseButton as a data-testid to the side panel's close button.
• src/components/visual/button/button.tsx
  • Changed the handleClick method to readonly and commented out a direct data-testid assignment, indicating it's handled by a prop.
• src/constants/dataTestIds.enum.ts
  • Added sidePanelCloseButton to the DataTestIdsEnum.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a new version, updates the changelog, and adds a new data-testid for the side panel close button. However, there is a critical issue regarding the data-testid implementation for the mvx-button component, which appears to have been inadvertently removed, impacting testability. Additionally, a minor typo was found in the changelog.

[gemini-code-assist]

Commenting out the data-testid attribute here means that the dataTestId prop passed to <mvx-button> will no longer be applied to the underlying <button> element. This breaks the intended functionality of providing a data-testid for testing purposes. The ButtonComponent (from common/Button/Button.tsx) correctly accepts and applies the data-testid prop, so it should be passed through.

Suggested change

	// data-testid={this.internalDataTestId} // This is handled by the `data-testid` prop with `reflect: false`
	data-testid={this.dataTestId}

[gemini-code-assist]

There appears to be a typo in the changelog entry. "Fied" should likely be "Fixed".

Suggested change

	- [Fied `data-testid`s](https://github.com/multiversx/mx-sdk-dapp-ui/pull/303)
	- [Fixed `data-testid`s](https://github.com/multiversx/mx-sdk-dapp-ui/pull/303)