0.1.21

[arhtudormorar]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor version update and refines the behavior of the data-testid attribute for the button component. The change ensures that the data-testid is consistently reflected on the component's host element, which can improve testability and accessibility. The project's version and changelog have been updated accordingly to reflect these modifications.

Highlights

• Button Component data-testid Reflection: The data-testid property on the button component (mvx-button) has been updated to reflect its value on the host element, in addition to the inner <button> element. This change removes the reflect: false setting from the @Prop decorator.
• Version Bump: The project version has been incremented from 0.1.20 to 0.1.21 in package.json.
• Changelog Update: The CHANGELOG.md file has been updated to include an entry for version 0.1.21, documenting the data-testid fix, and a minor wording correction was made to a previous entry.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• CHANGELOG.md
  • Added new entry for version 0.1.21.
  • Corrected wording in a previous changelog entry.
• package.json
  • Incremented package version to 0.1.21.
• src/components/visual/button/button.tsx
  • Changed data-testid property to reflect on the host element.

Activity

• No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request prepares for the 0.1.21 release by updating the version in package.json and adding a corresponding entry to CHANGELOG.md. It also includes a change to the data-testid prop definition in the button.tsx component. While this change cleans up the code by removing a redundant property, it doesn't fully address the issue of passing the data-testid to the underlying element, which I've noted in a review comment. This seems to be an incomplete fix that could impact testability.

[gemini-code-assist]

While removing the explicit reflect: false is a good cleanup since it's the default behavior, the data-testid is still not being utilized. The dataTestId prop is defined but isn't passed down to the inner ButtonComponent in the render method. As a result, the data-testid attribute will not be applied to the underlying <button> element, which likely defeats the purpose of having this prop for testing. To complete the fix, the dataTestId should be passed to the ButtonComponent.